search

pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.37k stars 529 forks source link

feat: no-detach #1264

Closed port19x closed 5 months ago

port19x commented 5 months ago

Pull Request Template

Type of change

Description

fixes #1261

Checklist

germaniuss commented 5 months ago

Awesome you're actually doing this. Locally I also removed the >/dev/null 2>&1 & at the end since I believe we do not want to redirect the mpv output (nor open it in a background process). Though to be fair I am not knowledgeble enough about bash nor terminal emulators to actually know is that make a difference.

port19x commented 5 months ago

Can you test if it works like this as well?

germaniuss commented 5 months ago

Awesome you're actually doing this. Locally I also removed the >/dev/null 2>&1 & at the end since I believe we do not want to redirect the mpv output (nor open it in a background process). Though to be fair I am not knowledgeble enough about bash nor terminal emulators to actually know is that make a difference.

@port19x Sorry for getting back to you so late, had a pretty hectic week. Just tested it out, it does not seem to properly function without this (the anime is played in the background and I have to pkill mpv. I modified the sript to do $([ "no_detach" == 0 ] && echo ">/dev/null 2>&1 &") ;; at the end and it seems to work. Is there any technical reason not to do it?

port19x commented 5 months ago

Awesome you're actually doing this. Locally I also removed the >/dev/null 2>&1 & at the end since I believe we do not want to redirect the mpv output (nor open it in a background process). Though to be fair I am not knowledgeble enough about bash nor terminal emulators to actually know is that make a difference.

@port19x Sorry for getting back to you so late, had a pretty hectic week. Just tested it out, it does not seem to properly function without this (the anime is played in the background and I have to pkill mpv. I modified the sript to do $([ "no_detach" == 0 ] && echo ">/dev/null 2>&1 &") ;; at the end and it seems to work. Is there any technical reason not to do it?

Nah, I'll patch it