pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.89k stars 542 forks source link

Asks for Windows dependencies when inside WSL 2 #1266

Closed tekunikaru closed 7 months ago

tekunikaru commented 8 months ago

Metadata Version: 4.7-1 (From AUR) OS: Arch Linux on Windows 10 x86_64 Shell: zsh

It doesn't work properly on Arch WSL. When executed, it thinks I'm on Windows (which is technically true). It gives the following output:

$ ani-cli
Checking dependencies...
Program "mpv.exe" not found. Please install it.

Steps To Reproduce

  1. Start Arch WSL
  2. Install ani-cli from AUR (I used yay)
  3. Run ani-cli

Expected behavior Dependency check should not ask for Windows applications when inside WSL

Screenshots image

Additional context I use Arch WSL 2 on Windows 10 with an X server service for GUI

Vergenter commented 8 months ago

Hello,

As a contributor who implemented the change to use Windows' mpv.exe for video playback with ani-cli under WSL, I wanted to clarify the rationale behind this approach:

Why Use Windows' mpv.exe with ani-cli in WSL:

How to use it:

This solution is designed to optimize the user experience by providing a practical and stable setup for enjoying videos with ani-cli. Your understanding and support in this matter are greatly appreciated.

To revert this change it is enough to remove from ani-cli | *WSL2* in two places. https://github.com/pystardust/ani-cli/blob/0a00507115d557fcba64c087dabeaef9f626e789/ani-cli#L303 https://github.com/pystardust/ani-cli/blob/0a00507115d557fcba64c087dabeaef9f626e789/ani-cli#L325

Pull request for context: https://github.com/pystardust/ani-cli/pull/1190