pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.89k stars 542 forks source link

fix: correctly closes escape sequence in message 'Checking dependencies…' #1272

Closed ochaton closed 8 months ago

ochaton commented 8 months ago

Pull Request Template

Type of change

Description

Hi, there! I've caught annoying UI bug on zsh when line "Checking dependencies..." is printed to stdout.

Before this patch it looks like this:

❯ ani-cli 'FLCL'
Checking dependencies...
                        [0m%

Symbol "\n" must be printed after resetting styles (or before them). And this patch is only about that:

❯ ./ani-cli 'FLCL'
Checking dependencies...

For maintaners

I am able to check basic functionality only on macos zsh and bash, I don't think that this patch somehow disturbes core functionality of the ani-cli.

If needed, I might bump patch version too, but I would better leave it for maintainers.

Checklist

Additional Testcases