search

pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.37k stars 529 forks source link

fix: no-detach detatching #1274

Closed port19x closed 3 months ago

port19x commented 5 months ago

https://github.com/pystardust/ani-cli/pull/1264#issuecomment-1925810856

port19x commented 5 months ago

I think shellcheck is a little confused here

germaniuss commented 5 months ago

Just tested out this MR and it does not seem to work. I feel like not redirecting the mpv output to /dev/null is necessary since when used with the kitty protocol the frames are sent through a bytestream from mpv to the terminal.

germaniuss commented 5 months ago

Just tested out this MR and it does not seem to work. I feel like not redirecting the mpv output to /dev/null is necessary since when used with the kitty protocol the frames are sent through a bytestream from mpv to the terminal.

By not work, I mean that the video is not showing. I no longer need to pkill the mpv process since it does not detach anymore, but the kitty protocol messages are not redirected to the terminal.

port19x commented 5 months ago

fixed, please try again to verify

germaniuss commented 5 months ago

Well that was fast haha, it does work now!!

port19x commented 5 months ago

On vacation doing some random coding currently :D

Derisis13 commented 3 months ago

oh wait, it did

port19x commented 3 months ago

Yeah, I wanted to be smart, but shellcheck didn't let me