search

pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.37k stars 529 forks source link

refactor: remove accidental awk and add ci-check for it #1309

Closed port19x closed 2 months ago

port19x commented 3 months ago

Pull Request Template

Type of change

Description

I briefly verified that the feature still works with naruto (finished), one piece (2 days) and boruto (multiple results)

port19x commented 3 months ago

Very well, it fails as it should

port19x commented 3 months ago

The second grep and the two cuts could be optimized away, but I don't think the gains are too noticable. How would that sed look like?

port19x commented 3 months ago

No code remains outside of the -N execution path. git diff 63b7b if you wanna verify

port19x commented 2 months ago

So is annyone gonna review this or do we just let awk rot in our codebase?