Closed Woreec closed 5 months ago
There's a reason why I introduced getting MyAnimeList Id directly from ani-skip, cache it in mal_id
variable when parsing cli arguments.
Line no. 424 should be:
[ "$skip_intro" = 1 ] && (dep_ch "ani-skip" || true) && mal_id=$(ani-skip -q "${skip_title:-${title}}")
In play_episode
function, it should be:
[ "$skip_intro" = 1 ] && skip_flag="$(ani-skip -q "$mal_id" -e "$ep_no")"
One can pass MyAnimeList ID directly to
--skip-title
and it would still work!
Ahhh, i see. I really should have just waited for you to do that, sorry about that i got a bit overzealous... I changed it to that now.
Ahhh, i see. I really should have just waited for you to do that, sorry about that i got a bit overzealous... I changed it to that now.
No problem. I hope you tested it once after making changes.
I did... but something is still odd actually it doesnt work with every anime. let me make it a draft again.. i feel so embarassed right now whew, sorry if im causing issues :^)
I did... but something is still odd actually it doesnt work with every anime. let me make it a draft again.. i feel so embarassed right now whew, sorry if im causing issues :^)
It may not be compatible with every anime due to the following reasons:
Yea, i figured out what the issue was i had, totally unrelated to this, had to do with my internet. I tested it now with One piece, frieren and some more and they all work perfecly fine, including using --skip_title So it really should work perfecly now.
I took the liberty to reword your PR title. Thanks for submitting
Also bump the patch version please
Ani-Skip has been updated, with changed start arg
Pull Request Template
Type of change
Ani-Skip has been updated, with changed start arg, so tiny fix for that.
Description
I hope this is okay this way. start arg now is -q [title] -e [episode]
Checklist
[x] bumped version
-c
history and continue work-d
downloads work-s
syncplay works-q
quality works-v
vlc works-e
select episode works-S
select index works-r
range selection works--skip
ani-skip works--skip-title
ani-skip title argument works--no-detach
no detach works--dub
and regular (sub) mode both work[ ] all providers return links (not necessarily on a single anime, use debug mode to confirm)
-h
help info is up to dateAdditional Testcases