pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.89k stars 542 forks source link

fix: adapt to ani-skip update #1313

Closed Woreec closed 5 months ago

Woreec commented 5 months ago

Ani-Skip has been updated, with changed start arg

Pull Request Template

Type of change

Ani-Skip has been updated, with changed start arg, so tiny fix for that.

Description

I hope this is okay this way. start arg now is -q [title] -e [episode]

Checklist

Additional Testcases

synacktraa commented 5 months ago

There's a reason why I introduced getting MyAnimeList Id directly from ani-skip, cache it in mal_id variable when parsing cli arguments.

Line no. 424 should be:


[ "$skip_intro" = 1 ] && (dep_ch "ani-skip" || true) && mal_id=$(ani-skip -q "${skip_title:-${title}}")

In play_episode function, it should be:

[ "$skip_intro" = 1 ] && skip_flag="$(ani-skip -q "$mal_id" -e "$ep_no")"

One can pass MyAnimeList ID directly to --skip-title and it would still work!

Woreec commented 5 months ago

Ahhh, i see. I really should have just waited for you to do that, sorry about that i got a bit overzealous... I changed it to that now.

synacktraa commented 5 months ago

Ahhh, i see. I really should have just waited for you to do that, sorry about that i got a bit overzealous... I changed it to that now.

No problem. I hope you tested it once after making changes.

Woreec commented 5 months ago

I did... but something is still odd actually it doesnt work with every anime. let me make it a draft again.. i feel so embarassed right now whew, sorry if im causing issues :^)

synacktraa commented 5 months ago

I did... but something is still odd actually it doesnt work with every anime. let me make it a draft again.. i feel so embarassed right now whew, sorry if im causing issues :^)

It may not be compatible with every anime due to the following reasons:

Woreec commented 5 months ago

Yea, i figured out what the issue was i had, totally unrelated to this, had to do with my internet. I tested it now with One piece, frieren and some more and they all work perfecly fine, including using --skip_title So it really should work perfecly now.

port19x commented 5 months ago

I took the liberty to reword your PR title. Thanks for submitting

port19x commented 5 months ago

Also bump the patch version please