Closed 0WN463 closed 1 month ago
I kinda get it, but I don't think this feature is desirable to a broader audience
Why not though?
We do have the -D, --delete
flag, which only deletes the history, so we do consider user flows which uses the history.
The delete flag only makes sense in the history-based flow, so it means we are support this flow.
So I feel that it makes sense to bolster the history-based flow by adding this feature.
This feature is not that bad, but the implementation was way too many loc. @port19x would you be against it if it were below 15 lines total?
We most definitely support history based flow, but I believe it's unwise to let ani-cli feature-creep into a local anilist equivalent. We can add it if derisis sees value, especially if we get it down to say +20 loc
+1 This is a bit too niche of a feature, i doubt anyone would be deep into this workflow.
Pull Request Template
Type of change
Description
A use case that I frequently have is that I want to add an anime to my histfile so that I can watch it later. This PR adds a flag
-a/--add
which allows us to simply add the anime without playing the episode.For these animes, we use
unwatched
to signify the "ep_no" field in the histfile. When parsing the histfile, we select the first episode in the episode listThis flag only significant in the case of using
-c
later. Standard operations ofani-cli
have no interaction with this flag.PS: I tried running
shfmt
, but it is flagging a lot of changes in the latest masterChecklist
[x] bumped version
-c
history and continue work-d
downloads work-s
syncplay works-q
quality works-v
vlc works-e
select episode works-S
select index works-r
range selection works--skip
ani-skip works--skip-title
ani-skip title argument works--no-detach
no detach works--dub
and regular (sub) mode both work[ ] all providers return links (not necessarily on a single anime, use debug mode to confirm)
-h
help info is up to dateAdditional Testcases