search

pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.34k stars 530 forks source link

Outplayer Support (iOS) #1351

Closed bbb651 closed 1 month ago

bbb651 commented 1 month ago

Is your feature request related to a problem? Please describe. (It's funny how perfect the issue template is for this issue) There is a better player for iOS users than VLC. It's called Outplayer and is a mpv frontend written in swift. It bugs me that I can't use it without manually editing the script, which is a bit annoying to do on iOS.

Describe the solution you'd like Add support for outplayer links, maybe with a generic -p for player flag rather than a player specific -v (e.g. -pvlc, -poutplayer) that would trigger player specific logic for known players, or a warning and generic opening logic (<player> <stream> for desktop, <player>://<stream> link on iOS) for unknown players (maybe with an additional option to only allow known players for security). The uri of outplayer is identical to vlc, so even the generic support is enough.

Describe alternatives you've considered Replace VLC as the default on iOS (could also be done in addition to the flag).

Additional context Outplayer is MUCH better designed than VLC on iOS, and a lot more lightweight (also half the size). It's not open source but it has no collected data and it's fully functional and never a bugs without the full version.

Derisis13 commented 1 month ago

While we work on this, you can set the environment variable ANI_CLI_PLAYER to the path or command to outplayer. We might take a while since none of us has an iphone to test on. If you have a working solution, a PR would be appreciated.

bbb651 commented 1 month ago

I can make a pr, which option would you prefer? ANI_CLI_PLAYER seems to completely override the command (which is useful on it’s own), where -p is a generic version of -v that tries to be compatible with both desktop and iOS. Also about VLC/Outplayer as the default, it is a breaking change although people don’t update on iOS often since it’s annoying to do so.

Derisis13 commented 1 month ago

Since Outplayer is iOS only, it should be treated like iina on macos

port19x commented 1 month ago

I'm closing this in favor of #1350, so we can have a centralized discussion there. Thank you for contributing to better support for iOS