pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.34k stars 530 forks source link

docs: added FreeBSD installation instructions #1361

Closed ChromiumOS-Guy closed 4 weeks ago

ChromiumOS-Guy commented 1 month ago

Pull Request Template

Type of change

Description

I added Tier 2 FreeBSD support using the linuxemu (aka Linux ABI) which is very simple to setup.

Checklist

Additional Testcases

ChromiumOS-Guy commented 1 month ago

forgot to mention that ani-skip doesn't work on FreeBSD , should add that warning first

71zenith commented 1 month ago

Does ani-cli not work without linuxemu on FreeBSD? We aim to remain posix compatible therefore it should run on any unix system without any layer. It's just a shellscript afterall

71zenith commented 1 month ago

Am open to adding this to docs , but I would like to not have any more moving parts than necessary.

ChromiumOS-Guy commented 1 month ago

I am not near my pc right now but I'll check if it works without linux emu (by disabling it)

also its not modified it just works (except ani-skip which i need to investigate further)

if by moving parts you mean more OSs to support that I agree , though I did state in the docs it is not supported so you are committing to nothing long term so I hope that helps (I'll try to support it though).

ChromiumOS-Guy commented 1 month ago

also how does one enter debug mode on ani-cli because I didn't find any docs for it (though that's probably me being stupid)

71zenith commented 1 month ago

By moving parts, i meant linuxemu being a middleman

71zenith commented 1 month ago

also how does one enter debug mode on ani-cli because I didn't find any docs for it (though that's probably me being stupid)

debug? if u just want to print the links then ANI_CLI_PLAYER=debug ani-cli <args> if u want it to print all the commands being run then sh -x $(which ani-cli) <args> sh -x is universal to any shell script so using it on ani-skip will also work

71zenith commented 1 month ago

I am not near my pc right now but I'll check if it works without linux emu (by disabling it)

also its not modified it just works (except ani-skip which i need to investigate further)

if by moving parts you mean more OSs to support that I agree , though I did state in the docs it is not supported so you are committing to nothing long term so I hope that helps (I'll try to support it though).

Fair, I've employed quite a number of hacks to get ani-skip working. Do report on what error ani-skip exits. Ill try to fix it.

ChromiumOS-Guy commented 1 month ago

Np, and thanksfor the help with the debug stuff, I'll get to it in ~1.5h when I'm home.

ChromiumOS-Guy commented 1 month ago

yeah turns out you don't need linux emu , so all is good on that part (removed it from docs) I just assumed that from some reason even though it says in the docs its for unix based OSs which is just fun, sorry for the confusion.

ChromiumOS-Guy commented 1 month ago

well the debug stuff says all linkes fetched which is nice, also I noticed this:

dropbox Links Fetched
sharepoint Links Fetched
sed: 1: "s|^#.*x||g; s|,.*|p|g;  ...": unterminated substitute pattern
gogoanime Links Fetched

it seems to have no effect on functionality (and frankly I have no Idea what you do with sed editor) also with debug I was able to get this:

$ ANI_CLI_PLAYER=debug ani-cli one piece --skip
Skip times not found!

so I just tried a movie (betting those probably had time skips) and it works just fine!

ChromiumOS-Guy commented 1 month ago

forgot to say, yes --skip-title also works

ChromiumOS-Guy commented 1 month ago

so yeah everything works, no linuxemu required If you pull I'll probably update this if something needs to be changed (which knowing FreeBSD probably means never or maybe maybe when FreeBSD 15 drops proper)

justchokingaround commented 1 month ago

please remove the part where each dependency is installed on its own, it's redundant

ChromiumOS-Guy commented 1 month ago

Sure!, done. I just copied the style of the Steamdeck support but I don't mind at all.

justchokingaround commented 4 weeks ago

great, thanks for your contribution!