pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.34k stars 530 forks source link

fix: allow using --select-nth with --continue #1362

Closed FireEgl closed 3 weeks ago

FireEgl commented 1 month ago

When there's multiple animes to choose from when using --continue, --select-nth will do what you expect.

Pull Request Template

Type of change

Description

I wanted to be able to automate downloading multiple animes even when there's several to choose from when doing --continue This code adds a check for --select-nth and if specified uses that instead of prompting interactively.

Checklist

Additional Testcases

71zenith commented 1 month ago

Welcome addition, but ill just say, all the requests are made in async, so the order of anime will be different for each run. making -S useless for predicting the index

justchokingaround commented 1 month ago

image ??

FireEgl commented 1 month ago

image ??

It's the same code I copied from a few lines down.. I didn't think too hard about the logic of it.. and I'm not great at writing sh script, I just figured it was "normal" for sh. Why wasn't this written in bash anyway? It could be a little better looking that way..

CoolnsX commented 4 weeks ago

@FireEgl cause of POSIX compliance, bash has extra features that are not in POSIX standard.

port19x commented 4 weeks ago

Welcome addition, but ill just say, all the requests are made in async, so the order of anime will be different for each run. making -S useless for predicting the index

Is this always the case? If so, I'd like to deprecate that feature

71zenith commented 4 weeks ago

Welcome addition, but ill just say, all the requests are made in async, so the order of anime will be different for each run. making -S useless for predicting the index

Is this always the case? If so, I'd like to deprecate that feature

-S ? . It is quite consistent for the search feature unless allanime itself modifies the names(one piece,black cloverrenaming to avoid copyrights). For history though, it is pretty much random

port19x commented 4 weeks ago

Then -S won't get deprecated, nice

port19x commented 3 weeks ago

I just stared at these merge conflicts for like 20 minutes and am gonna cut my losses here. This, at it's current state, is irreconcilable with the prior PR. Please adapt and resubmit