Closed FireEgl closed 3 weeks ago
Welcome addition, but ill just say, all the requests are made in async, so the order of anime will be different for each run. making -S useless for predicting the index
??
??
It's the same code I copied from a few lines down.. I didn't think too hard about the logic of it.. and I'm not great at writing sh script, I just figured it was "normal" for sh. Why wasn't this written in bash anyway? It could be a little better looking that way..
@FireEgl cause of POSIX compliance, bash has extra features that are not in POSIX standard.
Welcome addition, but ill just say, all the requests are made in async, so the order of anime will be different for each run. making -S useless for predicting the index
Is this always the case? If so, I'd like to deprecate that feature
Welcome addition, but ill just say, all the requests are made in async, so the order of anime will be different for each run. making -S useless for predicting the index
Is this always the case? If so, I'd like to deprecate that feature
-S
? . It is quite consistent for the search feature unless allanime itself modifies the names(one piece,black cloverrenaming to avoid copyrights). For history though, it is pretty much random
Then -S
won't get deprecated, nice
I just stared at these merge conflicts for like 20 minutes and am gonna cut my losses here. This, at it's current state, is irreconcilable with the prior PR. Please adapt and resubmit
When there's multiple animes to choose from when using --continue, --select-nth will do what you expect.
Pull Request Template
Type of change
Description
I wanted to be able to automate downloading multiple animes even when there's several to choose from when doing --continue This code adds a check for --select-nth and if specified uses that instead of prompting interactively.
Checklist
[ ] bumped version
-c
history and continue work-d
downloads work-s
syncplay works-q
quality works-v
vlc works-e
select episode works-S
select index works-r
range selection works--skip
ani-skip works--skip-title
ani-skip title argument works--no-detach
no detach works--dub
and regular (sub) mode both work[ ] all providers return links (not necessarily on a single anime, use debug mode to confirm)
-h
help info is up to dateAdditional Testcases