pystardust / ani-cli

A cli tool to browse and play anime

GNU General Public License v3.0

7.34k stars 530 forks source link

feat: initial logger support #1370

Open 71zenith opened 2 weeks ago

71zenith commented 2 weeks ago

Pull Request Template

Type of change

[ ] Bug fix
[ ] Feature
[ ] Documentation update

Description

ramble here

Checklist

[ ] any anime playing
[ ] bumped version
[ ] next, prev and replay work
[ ] -c history and continue work
[ ] -d downloads work
[ ] -s syncplay works
[ ] -q quality works
[ ] -v vlc works
[ ] -e select episode works
[ ] -S select index works
[ ] -r range selection works
[ ] --skip ani-skip works
[ ] --skip-title ani-skip title argument works
[ ] --no-detach no detach works
[ ] --dub and regular (sub) mode both work
[ ] all providers return links (not necessarily on a single anime, use debug mode to confirm)
[ ] -h help info is up to date
[ ] Readme is up to date
[ ] Man page is up to date

Additional Testcases

The safe bet: One Piece
Episode 0: Saenai Heroine no Sodatekata ♭
Unicode: Saenai Heroine no Sodatekata ♭
Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

71zenith commented 1 week ago

@port19x it seems that journalctl cleans up the logs every few days? do u still wanna proceed with this feature

justchokingaround commented 1 week ago

:/

port19x commented 1 week ago

@port19x it seems that journalctl cleans up the logs every few days? do u still wanna proceed with this feature

That's configured by the distro, on arch I still have logs from march. I'd say let's proceed

71zenith commented 1 week ago

i'd like someone to test this on mac @justchokingaround free?

port19x commented 1 week ago

I have a m1 macbook air that I bought used like 2 weeks ago. I can do the testing if I remember

71zenith commented 1 week ago

@port19x did u test?

port19x commented 1 week ago

I didn't forget to check, but I forgot this is already done, since it's still a draft PR. I was confused by your inactivity. Will test later today

port19x commented 1 week ago

Not quite there yet. Ani-cli -l hangs

Screenshot 2024-06-26 at 07 28 55

71zenith commented 1 week ago

can u check the docs to see how to print the logs. its hard for me to rely on stack overflow and random forums

port19x commented 1 week ago

Yeah, but might not get to it today

port19x commented 3 days ago

I had to take care of an elephant this weekend. I'll see that I get this done sometime this week.

the elephant in question

CoolnsX commented 3 days ago

I had to take care of an elephant this weekend. I'll see that I get this done sometime this week.

the elephant in question

Noice, well it's a great language, and it will be like a stain on ur life 🙃