search

pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.89k stars 542 forks source link

Receive "Episode not released!" even though the episode is released on allanime.to #1429

Closed Lugas7 closed 1 week ago

Lugas7 commented 1 week ago

Version: 4.9.0 OS: Arch Linux Shell: bash Anime: Kami No Tou (Tower of god season 2)

description

Get "Episode not released!" when the episode is realeased on allanime.to.

Steps To Reproduce

Happens when I try to watch an episode which is tracked in ani-cli and can thence be selected, but it fails. Think it has something to do with the episode only recently being released (as of my attempt, the episode has only been released 5 hours ago on allanime.to)

Expected behavior Should be able to watch episode

HirschBerge commented 1 week ago

Also happening on 4.9.0 on NixOS unstable. Has been happening with every episode released in the last 24-36 hours or so that I'm watching. Tower of God, Monogatari, Fairy Tail 100YQ, etc. Saw something similar a few weeks ago that eventually resolved itself I believe.

71zenith commented 1 week ago

We scrape only a small subset of video providers from allanime. Most of the times when a new episode is released it only has providers we dont scrape.

Lugas7 commented 1 week ago

Ah ok, is there an issue for increasing the number of providers scraped? I might be interested in attempting developing that at some point when I have time

HirschBerge commented 1 week ago

We scrape only a small subset of video providers from allanime. Most of the times when a new episode is released it only has providers we dont scrape.

How is this a resolution? Is there an issue/pr to add more providers to scrape this can at least be linked to?

71zenith commented 1 week ago

Ah ok, is there an issue for increasing the number of providers scraped? I might be interested in attempting developing that at some point when I have time

No mostly, as long as the code isnt too complicated. you can start by looking at the current scrapers https://github.com/pystardust/ani-cli/blob/5daa876a3c88544ee7a21aac4704e14be519c25a/ani-cli#L131-L197

71zenith commented 1 week ago

How is this a resolution? Is there an issue/pr to add more providers to scrape this can at least be linked to?

https://github.com/pystardust/ani-cli/pull/1410 There is a pr to add back a provider.

71zenith commented 1 week ago

Generally we don't add more cause the current providers are the most stable and don't break unexpectedly

Lugas7 commented 1 week ago

One quick improvement would be to change the error message in this event, it is in fact incorrect to say that the episode is not released yet. Perhaps something along the lines of: "episode has not been released in a provider we support" may be better.

I would not have made this issue as a bug if I got a better error message.