search

pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.81k stars 540 forks source link

Episode 1/0 error #152

Closed Austinrocket closed 2 years ago

Austinrocket commented 2 years ago

Some anime that are just a single episode show as: "Choose episode [1-0]:" Choosing 1 says it's out of bounds and choosing 0 opens the player but cannot resolve the URL

The most popular example I could find would be with the newest BnHA movie: "$ ani-cli Search Anime: my hero [1] maoyuu-maou-yuusha ... [11] boku-no-hero-academia-the-movie-3 ... [20] boku-no-hero-academia-the-movie-2-heroesrising-dub Enter number: 11 Choose episode [1-0]: 0 Episode out of range Choose episode [1-0]: 1 Getting data for episode 1

Currently playing boku-no-hero-academia-the-movie-3 episode 0/0 [n] next episode [p] previous episode [s] select episode [r] replay current episode [q] exit Enter choice: q"

Not sure what could resolve this issue atm, just wanted to report it.

Thanks!

Reaper176 commented 2 years ago

i am also doing the boku no hero. small world. same issue.

Austinrocket commented 2 years ago

Yeah very strange. Must be some weird indexing edge case...

Rendevior commented 2 years ago

I checked it.. and yeah, the episode/movie is not released yet.. i think they must fix this or they write a script that check if Episode exist or the Series/Movie does have episode or not.

Austinrocket commented 2 years ago

Ohh I see, there is a listing for it but no actual content to pull... We should be checking to see if the content exists or not for sure. Thanks for the insight.

Derisis13 commented 2 years ago

This is an error caused by gogoanime changing their domain from www. to www1., and the fix is out. Do a git pull, then make uninstall && make install to upgrade.

port19x commented 2 years ago

Can confirm this is still an issue, at least for the anime mentioned above. Most movies work fine

port19x commented 2 years ago

@RaynardGerraldo can you take a look?

RaynardGerraldo commented 2 years ago

@RaynardGerraldo can you take a look?

Sure,ill take a look at it later,can you specify the animes that are still outputting this problem? Because i saw this issue couple of days ago and tried the boku no hero movie and it worked

port19x commented 2 years ago

Can you recheck? Didn't work for me

RaynardGerraldo commented 2 years ago

Can you recheck? Didn't work for me

yep, boku-no-hero-academia-the-movie-2-heroesrising-dub works, but boku-no-hero-academia-the-movie-3 still doesnt work,and the only reason why it doesnt work is because no episode has been released in gogoanime, status ongoing https://www2.gogoanime.cm/category/boku-no-hero-academia-the-movie-3

RaynardGerraldo commented 2 years ago

Can you recheck? Didn't work for me

since this is a problem that can only be solved until gogoanime actually uploads something, i just added check if theres no episode then output error message, did this on my end,should i do a pr?

port19x commented 2 years ago

Sounds good, it gives an error message for that movie? Best we can do

RaynardGerraldo commented 2 years ago

Sounds good, it gives an error message for that movie? Best we can do

Yep,just made a pr you can test out the commit