search

pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.92k stars 544 forks source link

Can we have a homebrew package #432

Closed port19x closed 2 years ago

port19x commented 2 years ago

Is your feature request related to a problem? Please describe. There are still occasional reports of weird installation problems from some mac users. Apart from that, this would obviously be better UX. Native packages are always best.

Describe the solution you'd like Someone create and maintain a homebrew package of ani-cli. I'll happily supply all the metadata you need.

Describe alternatives you've considered We could leverage the wiki to document edge cases and their workarounds. But that seems like bad form

Additional context Homebrew is the dominant package manager over on mac os

justchokingaround commented 2 years ago

on it

port19x commented 2 years ago

Tracking PR from homebrew core: https://github.com/Homebrew/homebrew-core/pull/94169

port19x commented 2 years ago

It seems like it will be very difficult to get ourselves included, considering their testing policy

4cecoder commented 2 years ago

It seems like it will be very difficult to get ourselves included, considering their testing policy

It seems to me that we could organize the project that would make our repo tap-able brew tap <direct_repo_url> && brew install <your repo's program> Lets reference: https://docs.brew.sh/Taps

justchokingaround commented 2 years ago

@4cecoder i already did that, you can do brew tap iamchokerman/ani-cli and then brew install ani-cli. That will install ani-cli

4cecoder commented 2 years ago

@iamchokerman let me know more about your fork and how often it is updated with master

justchokingaround commented 2 years ago

@iamchokerman let me know more about your fork and how it merges

you can find my fork at https://github.com/iamchokerman/homebrew-ani-cli/ basically to merge it with homebrew-core it's required to have a test it can pass (one that you make yourself inside the ruby file), to test whether or not it's working properly after the install. however idk how it can be possible to create such a test for ani-cli specifically. i created testdata at some point to compare the output of ani-cli -h with the text in testdata but that didn't work :( feel free to checkout this PR for more feedback / info : https://github.com/Homebrew/homebrew-core/pull/94169#pullrequestreview-867657397

thamognya commented 2 years ago

Thank you. It works on my macOS build.

port19x commented 2 years ago

I think we can consider this resolved, right?

justchokingaround commented 2 years ago

I think we can consider this resolved, right?

yeah, we can probably close the issue for now