pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.92k stars 544 forks source link

Non-integer episodes broken #441

Closed port19x closed 2 years ago

port19x commented 2 years ago

Metadata (please complete the following information) Version: v1.5.1 OS: Linux Mint 20.3 Shell: zsh Anime: arifureta-shokugyou-de-sekai-saikyou

Describe the bug When trying to watch episode 5.5 through our h5 convention it exits saying Invalid number entered

Steps To Reproduce

  1. Run ani-cli arifureta
  2. Choose 1 (arifureta-shokugyou-de-sekai-saikyou)
  3. Choose episode 1

Expected behavior For non-integer Episodes to be support Screenshots (if applicable) image

Additional context Looking for more non-integer episode anime to list in the Testing section of contributing.md

RaynardGerraldo commented 2 years ago

Metadata (please complete the following information) Version: v1.5.1 OS: Linux Mint 20.3 Shell: zsh Anime: arifureta-shokugyou-de-sekai-saikyou

Describe the bug When trying to watch episode 5.5 through our h5 convention it exits saying Invalid number entered

Steps To Reproduce

1. Run `ani-cli arifureta`

2. Choose 1 (arifureta-shokugyou-de-sekai-saikyou)

3. Choose episode 1

Expected behavior For non-integer Episodes to be support Screenshots (if applicable) image

Additional context Looking for more non-integer episode anime to list in the Testing section of contributing.md

this was fixed in #429

port19x commented 2 years ago

Duplicate of #428

port19x commented 2 years ago

I have no idea what happened but now I can't reproduce the error anymore. Could have sworn that was on master. Guess I'll close