pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.92k stars 544 forks source link

[Enhancement] Deprecating Git Bash from Windows installation #446

Closed sadkris closed 2 years ago

sadkris commented 2 years ago

In what category does your enhancement fall? [choose: safety, speed, ux, qa, other] ux

Status Quo Currently, Git Bash is used to run and install ani-cli

The Enhancement Write a Batch (ew) script to use in the root directory to download requirements, and create a replacement for the batch script, being an exe to automatically redirect to the python code, sending options with it.

sadkris commented 2 years ago

I'll start working on this when I get off work later

port19x commented 2 years ago

How about a chocolatey package? How about a scoop pacakge? scoop > chocolatey from my limited research

sadkris commented 2 years ago

The goal is to minimize the amount of steps for the end user. It'd be best just to limit it to a "Download repo, run installer, run command from cmd" deal

port19x commented 2 years ago

Work on a proof of concept, but things may not get merged

sadkris commented 2 years ago

Oh they'll get merged.

sadkris commented 2 years ago

In what category does your enhancement fall? [choose: safety, speed, ux, qa, other] ux

Status Quo Currently, Git Bash is used to run and install ani-cli

The Enhancement Write a Batch (ew) script to use in the root directory to download requirements, and create a replacement for the batch script, being an exe to automatically redirect to the python code, sending options with it.

Funny Kris thinks the code is Python. I can still try to port it easily

sadkris commented 2 years ago

Fuck Batch I'm porting it to Python

port19x commented 2 years ago

Fuck Batch I'm porting it to Python

Porting what? ani-cli? Have fun maintaining a fork. Get in touch with Incndev, he maintains a crystal version of ani-cli

port19x commented 2 years ago

Closing in favor of either a spereate for or #448