search

pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.86k stars 540 forks source link

Option -q doesn't work with -d #603

Closed rbjnazz closed 2 years ago

rbjnazz commented 2 years ago

Version: 1.9.3 OS: Linux Mint 20.2 Shell: zsh Anime: anything

Describe the bug -q option always defaults to best quality when downloading

Steps To Reproduce ani-cli -q 720 -d "one piece"

Expected behavior download the specified quality

CoolnsX commented 2 years ago

It's happening because there is no link with 720p... I know u can get it on official Website.. they kind of does something to segregate links from the source.. and we don't know how they do.. so quality option is not working due to this reason...

port19x commented 2 years ago

Streaming it in 720p seems to work

rbjnazz commented 2 years ago

It's happening because there is no link with 720p... I know u can get it on official Website.. they kind of does something to segregate links from the source.. and we don't know how they do.. so quality option is not working due to this reason...

Its working on v1.7 and v1.8 ('I can download any quality from 360p to 1080p) until v1.9 m3u8 update broke it.

port19x commented 2 years ago

It's happening because there is no link with 720p... I know u can get it on official Website.. they kind of does something to segregate links from the source.. and we don't know how they do.. so quality option is not working due to this reason...

Its working on v1.7 and v1.8 ('I can download any quality from 360p to 1080p) until v1.9 m3u8 update broke it.

I think you may be a little confused. Since this is a web scraper, we constantly adapt to changes made by gogo. To have any version of ani-cli work for longer than a month is a luxury for us. Yes, during the times of v1.7 and v1.8, this wasn't an issue. But then gogo screwed something and we haven't yet found ways to remedy the issue and are confident that ther might be none.

If gogoanime continues to put as much effort into resisting our scraping as they have been doing over the past several weeks, we may at some point switch to another provider, where this may be different. Until then fingers crossed

port19x commented 2 years ago

In my testing with flcl prior to the release of v2, -q and -d did work together. This confirms my theory that this is due to m3u8 downloads. I'm closing this, as it's not really a bug.

If you want lower quality to save storage space, consider transcoding the highest quality to a resolution of your choice using ffmpeg