pystardust / ytfzf

A posix script to find and watch youtube videos from the terminal. (Without API)
GNU General Public License v3.0
3.71k stars 351 forks source link

[BUG]: Missing gtkdialog for the gui extension #558

Open brauliohms opened 2 years ago

brauliohms commented 2 years ago

Describe the bug

I have see that when you try to use the gui extension it complain the missing gtkdialog executale

To Reproduce

ytfzf --ext=gui

Expected behavior

Open new gtk windows

Information

Additional context

Dear pystardust, I am a contributor to the Debian project and packaged your great program and uploaded it to Debian. (https://salsa.debian.org/debian/ytfzf) or in my salsa up-to date (https://salsa.debian.org/braulio/ytfzf).

I have see that when you try to use the gui extension it complain the missing gtkdialog executale:

$ export YTFZF_SYSTEM_ADDON_DIR="/usr/share/ytfzf/addons/" $ LANG=C ytfzf --ext=gui gtkdialog (https://github.com/puppylinux-woof-CE/gtkdialog) is required for the gui extension

but, if I don't mistake, this is not in Debian: $ apt-file search bin/gtkdialog $

I found that gtkdialog was removed from Debian in 2009 because it is not anymore supported upstream and there are other alternatives.

Euro20179 commented 2 years ago

Not going to lie, that addon only exists because I stumbled across gtkdialog and I hadn't seen anything of that sort before, and I wanted to see if I could make a gui interface for ytfzf, so I did. Of course yad, and zenity exist, but they don't support custom css to my knowledge. In addition I really don't feel like rewriting that addon.

To me gtkdialog looks supported because the last release was june 6th, but that doesn't change the fact that it's not in the debian repos. In my opinion there are 2 solutions to this problem.

  1. Don't package the addons along with ytfzf (the ytfzf package on the aur does this)
  2. The gui addon gets moved to it's own repo
brauliohms commented 2 years ago

Ok thanks for the explanation. I chose to keep this add-on uninstalled on Debian until I or someone else can package gtkdialog and get it back into Debian.

Euro20179 commented 2 years ago

Cool that works, since the issue is not really fully resolved, it's your choice if you want to close it.