pystardust / ytfzf

A posix script to find and watch youtube videos from the terminal. (Without API)
GNU General Public License v3.0
3.78k stars 343 forks source link

[BUG]: videos in a channel are listed twice when using `ytfzf -c invidious-channel` #667

Closed kevenwyld closed 1 year ago

kevenwyld commented 1 year ago

Describe the bug

Videos in a channel are listed twice when using ytfzf -c invidious-channel. So every video has two entries in the fzf list.

To Reproduce

For example run ytfzf -c invidious-channel https://www.youtube.com/channel/UC2wdo5vU7bPBNzyC2nnwmNQ

Expected behavior

Only one entry per video

Screenshots

Screenshot_2023-03-30_21-40-55

Information

Additional context

I have is_sort=1 in my config file which makes this issue very noticeable. It's still there without that parameter, but since videos aren't sorted by date it's less obvious.

This does not happen when scraping subscriptions from a subscription file with ytfzf -cSI

Thanks as always!

Euro20179 commented 1 year ago

I am not able to reproduce this both in the development branch and on version 2.5.5. What invidious instance was used when this was scraped?

kevenwyld commented 1 year ago

At the time it was all invidious instances, gathered by the first-run script to find healthy instances.

There is an upstream issue with invidious channels right now. It was either causing the issue or has changed the behavior since yesterday.

A lot of invidious stuff is broken right now so I'll circle back to this one in a day or two when instances have updated and see if I can reproduce it again. Right now running the above command returns [ERROR]: Nothing was scraped against all the instances I've tried so far. (EDIT: Which has nothing to do with ytfzf, running curl against https://<instance>/api/v1/channels/UC2wdo5vU7bPBNzyC2nnwmNQ/videos returns a 500.)

kevenwyld commented 1 year ago

I've tested a few instances that have been updated so far and I think it's safe to say this was caused by youtube's upstream changes. I'm no longer experiencing this so I'm going to close the issue. Thanks!

Euro20179 commented 1 year ago

Awesome, good to know that the instances are working properly again!