pystardust / ytfzf

A posix script to find and watch youtube videos from the terminal. (Without API)
GNU General Public License v3.0
3.78k stars 343 forks source link

[BUG]: Minor output bug after selecting video #702

Open guiltiest-gear opened 1 year ago

guiltiest-gear commented 1 year ago

Describe the bug

After selecting a video to play, a blank line and the literal characters of ${new_line} show up in the output

To Reproduce

  1. Install ytfzf 2.6.1
  2. Enable thumbnails in config or with command line option
  3. Search for a video
  4. Notice how there is a blank like after the scraping message, and the string of ${new_line} appended to Fetching thumbnails...

    Expected behavior

    There should be no blank like and no extra characters

    Screenshots

    Screenshot_2023-09-17_18-47-21

Information

Additional context

This bug doesn't occur in 2.6.0, so it must be from a commit between 2.6.0 and 2.6.1

Euro20179 commented 1 year ago

I believe this is fixed in the development branch, you could try using that.

guiltiest-gear commented 1 year ago

I'll clone to the latest commit and get back to you on that

guiltiest-gear commented 1 year ago

Newest commit fixes ${new_line} bug, but extra blank line is still present Screenshot_2023-09-18_14-27-02