search

pystiche / papers

Reference implementation and replication of prominent NST papers
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Internal / external pre- and postprocessing #153

Closed pmeier closed 4 years ago

pmeier commented 4 years ago

Since all papers we implemented so far use a VGG net with caffe weights as encoder, pre- and postprocessing is necessary. IIRC this isn't mentioned in any paper.

Right now we assume that the authors are using an internal preprocessing, i. e. as a first step within the encoder. This is not the normal course of action. Although this might be beneficial at runtime, we should consider using the external processing as default.

Cc @jbueltemeier

jbueltemeier commented 4 years ago

The pre- and postprocessing is necessary because of the VGG net with caffe weights used and was not introduced by the authors, but only integrated into the implementation because of the necessity. For this reason, I think it would make sense to completely do without the external preprocessing and use only the internal one?

This does not change anything in the original implementation, but only benefits from the internal preprocessing given by the repository of pystiche.

What do you think of my thoughts?

pmeier commented 4 years ago

Never mind. My main assumption is wrong.