pystiche / papers

Reference implementation and replication of prominent NST papers
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Add sanakoyeu_et_al_2018 data #162

Closed jbueltemeier closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #162 into sanakoyeu-2018 will decrease coverage by 0.0%. The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           sanakoyeu-2018    #162     +/-   ##
================================================
- Coverage            98.5%   98.5%   -0.1%     
================================================
  Files                  41      40      -1     
  Lines                1455    1412     -43     
================================================
- Hits                 1434    1391     -43     
  Misses                 21      21             
Impacted Files Coverage Δ
pystiche_papers/sanakoyeu_et_al_2018/__init__.py 100.0% <0.0%> (ø)
pystiche_papers/sanakoyeu_et_al_2018/_modules.py

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 86cbf53...046a8ad. Read the comment docs.

jbueltemeier commented 4 years ago

There is still an image augmentor missing which modifies the randomly selected image from the dataset by some transformations like scaling or rotation. See here. I don't think that this is a part of the image_transform, but one that belongs to the batch_sampler. Or what do you think?

pmeier commented 4 years ago

@jbueltemeier During rebase, I accidentally removed the commits you made to this branch today. Could you re-add them?

pmeier commented 4 years ago

@jbueltemeier The augmentation proved to be a lot of more work than I expected. I'll merge this now and add them in a follow-up PR.

pmeier commented 4 years ago

Superseded by #177.