pystiche / papers

Reference implementation and replication of prominent NST papers
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Hyper-parameters: proof of concept #181

Closed pmeier closed 4 years ago

pmeier commented 4 years ago

Addresses #167

This adds the HyperParameters class that should be used to hold all hyper parameters of a paper. For the proof of concept I'm applying this only to gatys_ecker_bethge_2016 for now.

ToDo:

codecov[bot] commented 4 years ago

Codecov Report

Merging #181 into hyperparameters will increase coverage by 0.0%. The diff coverage is 100.0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           hyperparameters    #181   +/-   ##
===============================================
  Coverage             98.7%   98.8%           
===============================================
  Files                   38      39    +1     
  Lines                 1406    1450   +44     
===============================================
+ Hits                  1389    1433   +44     
  Misses                  17      17           
Impacted Files Coverage Δ
pystiche_papers/gatys_ecker_bethge_2016/_loss.py 100.0% <100.0%> (ø)
pystiche_papers/gatys_ecker_bethge_2016/_nst.py 100.0% <100.0%> (ø)
pystiche_papers/gatys_ecker_bethge_2016/_utils.py 100.0% <100.0%> (ø)
pystiche_papers/utils/__init__.py 100.0% <100.0%> (ø)
pystiche_papers/utils/hyper_params.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bef7e1f...b34a53c. Read the comment docs.

pmeier commented 4 years ago

@jbueltemeier you can ignore the small compatibility changes to the conftest.py files for your review.