pystiche / papers

Reference implementation and replication of prominent NST papers
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Add Sanakoyeu 2018 gan loops #192

Closed jbueltemeier closed 4 years ago

pmeier commented 4 years ago

Blocked by #176 and #189. I'll review after these are merged.

jbueltemeier commented 4 years ago

I will add the tests later when the loops are ready.

codecov[bot] commented 4 years ago

Codecov Report

Merging #192 into sanakoyeu-2018 will decrease coverage by 2.5%. The diff coverage is 20.2%.

Impacted file tree graph

@@               Coverage Diff                @@
##           sanakoyeu-2018    #192     +/-   ##
================================================
- Coverage            97.9%   95.4%   -2.6%     
================================================
  Files                  44      45      +1     
  Lines                2046    2115     +69     
================================================
+ Hits                 2005    2019     +14     
- Misses                 41      96     +55     
Impacted Files Coverage Δ
pystiche_papers/sanakoyeu_et_al_2018/_nst.py 19.1% <19.1%> (ø)
pystiche_papers/sanakoyeu_et_al_2018/__init__.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 150b20c...a5a7df6. Read the comment docs.

pmeier commented 4 years ago

@jbueltemeier If you are happy, you can merge this. I'll add tests later myself.