pystiche / papers

Reference implementation and replication of prominent NST papers
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Adjusting the output filenames depending on impl_params #275

Closed jbueltemeier closed 2 years ago

jbueltemeier commented 2 years ago

There are currently scripts to create the images for the parameters from the reference implementation as well as for the paper. However, the file name is currently the same for both scripts. Therefore, I would suggest that similar to johnson_et_al_2016, the name is adjusted depending on impl_params so that the files are not overwritten when both variants are created.

Example: gatys_ecker_betghe_2016 Current: "_fig_2_d.jpg" New: "_fig_2d.jpg_" if impl_params else "_fig_2d_paper.jpg"

This would affect the scripts of: gatys_ecker_betghe_2016 gatys_et_al_2017 li_wand_2016

What do you think @pmeier ?

pmeier commented 2 years ago

SGTM, go for it!