pystiche / papers

Reference implementation and replication of prominent NST papers
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Change output filenames in replication scripts #276

Closed jbueltemeier closed 2 years ago

jbueltemeier commented 2 years ago

As mentioned in #275 the output file names are not yet ideal. This PR addresses this problem by making the file names more consistent. They now essentially consist of three components.

  1. The name of the replication.
  2. Additional parameters that are important for the name (figure labels, hyperparameters, ...).
  3. An optional flag indicating whether the impl_params are used.

Example of current filename: "_gatys_ecker_betghe_2016__fig_2Bimplparams.jpg"

codecov[bot] commented 2 years ago

Codecov Report

Merging #276 (a5ae25a) into main (0d8179d) will decrease coverage by 0.5%. The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #276     +/-   ##
=======================================
- Coverage   97.0%   96.5%   -0.6%     
=======================================
  Files         39      39             
  Lines       1639    1657     +18     
=======================================
+ Hits        1591    1600      +9     
- Misses        48      57      +9     
Flag Coverage Δ
unit 96.5% <100.0%> (-0.6%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pystiche_papers/utils/misc.py 90.4% <100.0%> (+0.1%) :arrow_up:
pystiche_papers/ulyanov_et_al_2016/_data.py 88.2% <0.0%> (-8.3%) :arrow_down:
pystiche_papers/ulyanov_et_al_2016/_utils.py 100.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d8179d...a5ae25a. Read the comment docs.