search

pystiche / papers

Reference implementation and replication of prominent NST papers
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

refactor weights URL selection for Johnson 2016 #90

Closed pmeier closed 4 years ago

pmeier commented 4 years ago

Due to the number of possible combinations this stores the weight URLs in a .csv rather than directly as a dictionary. Tests for this will be incorporated in #82.

This will not work until torch==1.6.0 hits since our download server requires a custom User-Agent in the download request. I've sent a patch for this that will be included in the upcoming release.

codecov[bot] commented 4 years ago

Codecov Report

Merging #90 into master will increase coverage by 0.3%. The diff coverage is 64.2%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #90     +/-   ##
========================================
+ Coverage    76.0%   76.4%   +0.3%     
========================================
  Files          37      37             
  Lines        1460    1463      +3     
========================================
+ Hits         1111    1118      +7     
+ Misses        349     345      -4
Impacted Files Coverage Δ
pystiche_papers/johnson_alahi_li_2016/core.py 100.0% <ø> (ø)
pystiche_papers/johnson_alahi_li_2016/modules.py 82.4% <64.2%> (+4.8%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b73755...61af822. Read the comment docs.