added virtualenv_name config

pystorm / streamparse

Run Python in Apache Storm topologies. Pythonic API, CLI tooling, and a topology DSL.

http://streamparse.readthedocs.io/

Apache License 2.0

1.5k stars 218 forks source link

added virtualenv_name config #373

Closed tanaysoni closed 7 years ago

tanaysoni commented 7 years ago

Introduced virtualenv_name in the config.json which overrides the default virtualenv(topology name) that streamparse uses when topologies are deployed.

This would take precedence over topology override_name and will only be used when use_virtualenv is True.

Issue 371

coveralls commented 7 years ago

Coverage decreased (-0.03%) to 48.005% when pulling 4b23aecfaf1d5ad5465f9b8f898712aa55996cc0 on tanaysoni:virtualenv_name into 4415ef6ec12b7410ffcabff93b41d9ce035c772d on Parsely:master.

coveralls commented 7 years ago

Coverage decreased (-0.03%) to 48.002% when pulling 2b0e6fcc0badc0a7fe5c520ab40b27ba621d94b7 on tanaysoni:virtualenv_name into 4415ef6ec12b7410ffcabff93b41d9ce035c772d on Parsely:master.

tanaysoni commented 7 years ago

Thank you @dan-blanchard for reviewing.

I've made the changes, please let me know if there's anything that I might have missed.