search

pystruct / pyqpbo

QPBO interface and alpha expansion for Python
23 stars 14 forks source link

Fix import problem #2

Closed fgregg closed 10 years ago

fgregg commented 10 years ago

This should fix the current import problem.

everything happy now

>>> import pyqpbo
>>> from pyqpbo import alpha_expansion_general_graph
amueller commented 10 years ago

Thanks. Why did you need the second commit for including the files in the build? It looked like it built fine.

amueller commented 10 years ago

sorry, some misclicks ;) thanks a lot, it does seem to work now! Hope travis agrees ;)

amueller commented 10 years ago

Travis disagrees :-/ https://travis-ci.org/pystruct/pystruct

amueller commented 10 years ago

I now made the test use only the installed inference methods. It think we should add another test, that separately tests which methods were installed correctly.

fgregg commented 10 years ago

Very frustrating. I added those the second commit because I was getting an undefined symbol error when I tried to import the module, http://stackoverflow.com/questions/11643666/python-importerror-undefined-symbol-for-custom-c-module.

I'll start a pull request for the new tests.

amueller commented 10 years ago

Yeah, I know it is frustrating. Thanks a lot for still working on it. I also got the import error, then picked your second commit and it was working in my virtualenv. No idea what the problem with travis is. I thought not relying on qpbo for the tests would be good, still having it easiliy installable would be great. But maybe there are more important and fun things to do ;)

amueller commented 10 years ago

at least now it seems to be easy to install in a normal virtualenv ;)

amueller commented 10 years ago

What do you want to work on for the new tests? I haven't really started yet, but I want to avoid duplicating effort.

fgregg commented 10 years ago

I'll start with pyqpbo, maybe just start with some simple tests to check if it's been installed.

On Thu, Jul 11, 2013 at 9:25 AM, Andreas Mueller notifications@github.comwrote:

What do you want to work on for the new tests? I haven't really started yet, but I want to avoid duplicating effort.

— Reply to this email directly or view it on GitHubhttps://github.com/amueller/pyqpbo/pull/2#issuecomment-20814949 .

773.888.2718 2231 N. Monticello Ave Chicago, IL 60647

amueller commented 10 years ago

Btw, did you mean working with travis was frustrating or are you frustrated that I changed the tests? I'm really sorry if it is the later.

fgregg commented 10 years ago

Oh no, travis is frustrating. Your test strategy makes sense.

On Thu, Jul 11, 2013 at 12:00 PM, Andreas Mueller notifications@github.comwrote:

Btw, did you mean working with travis was frustrating or are you frustrated that I changed the tests? I'm really sorry if it is the later.

— Reply to this email directly or view it on GitHubhttps://github.com/amueller/pyqpbo/pull/2#issuecomment-20826394 .

773.888.2718 2231 N. Monticello Ave Chicago, IL 60647