Open RudyFrom3 opened 6 years ago
Given a Depth of Flow from either a 1D link or an external 2D model, either a Rating Curve, or possibly better,.... code including the weir/orifice and submerged weir would identify the flow into a pit (node) {or storage} from which pit losses coefficients can be determined using the connected links and link flows as per the method described in OpenWaterAnalytics/pyswmm#134 This will provide many benefits to SWMM including a far more efficient way to model inlet capacity at inlet pits and a robust method to get dynamically allocated Pit Loss coefficients assigned.
It seems to me that there are to different things here: 1 - calculating the flow from/two a surface model 2 - calculating the pit loss due to the node inflow
I'll open an issue for the first one.
In resolving https://github.com/OpenWaterAnalytics/Stormwater-Management-Model/pull/124 related to the Pit Top object being created,
I have raised this in PySWMM ... but probably is best placed here ?
https://github.com/OpenWaterAnalytics/pyswmm/issues/134
This as mentioned also requires a cleaner method to determine the flow into a pit inlet? As suggested a rating curve, or Weir/Orifice Combination equation would suffice ??