Create some testing models

[bemcdonnell]

We need a set of models that will be run in CI for regression tests.

@aerispaha, @mehmetbercan, @rkertesz, @abhiramm7 would any of (or all of, or some of) you guys be interested in making a set of simple models that isolate some process thing? Ideally these models will run really fast and encompass all of the necessary components without the need for support files.

For example:

• RTK's
• Subcatchment Runoff
• LID's
• Controls
• GW/Aquifers
• (dare I say) Water Quality

[abhiramm7]

I can help with the controls part, is it just gate opening and closing or is there some other functionality that you feel should be included in control ?

[mehmetbercan]

Bryant,

I can help with some of the components once I am more into this. What you are doing here reminds me OpenMI that is well established standards for component based hydraulic and hydrological models. There are many components already available and many papers published on use and development of OpenMI. I am wondering if that can be used here.

Mehmet

On May 3, 2017, at 11:47 PM, Abhiram notifications@github.com wrote:

I can help with the controls part, is it just gate opening and closing or is there some other functionality that you feel should be included in control ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[bemcdonnell]

So @mehmetbercan, in other words, there is a complete collection of models somewhere? Can you add a link?

[mehmetbercan]

These scripts are in C# but the components are here anyway: https://hydrodesktop.codeplex.com/SourceControl/latest

Goto Source Code tab and under source/plugins/Plugins.Hydromodeller/components

Mehmet

On May 4, 2017, at 8:54 PM, Bryant E. McDonnell notifications@github.com wrote:

So @mehmetbercan, in other words, there is a complete collection of models somewhere? Can you add a link?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[aerispaha]

@mehmetbercan are there SWMM .inp files somewhere in that HydroDesktop source?

@bemcdonnell I help with the subcatchment model. Should I simply make a model that has a set of subcatchments with various hydrologic parameters?

[bemcdonnell]

I think this is all about isolating different behaviors. For example, if you're testing a runoff surface, send flow to a free outfall (and do not include a pipe network). If you're testing a controlling links (pumps, orifices and weirs), try to keep the network simple and straight forward. We are going to run these tests for tons of models.

@abhiramm7 Pumps on/off, orifices, weirs, and Conduits open/close. All of these as well as adjusting settings and such. Maybe even throw in a PID?

@aerispaha I'm thinking of a model with 100% impervious, a model with 100% pervious with infiltration with green ampt, horton, and all types, intra-routing. There will probably end up being quite a few models in the end.

@rkertesz Is going to do LID and GI stuff and I think he's going to coordinate collecting these models from everyone

@mehmetbercan can add the stuff i haven't thought of yet :-)

[mehmetbercan]

@aerispaha I know there is SWAT component but it is not on hydroshare. So, there might be SWMM component somewhere but I am not aware. And here it is (first thing came with google search): https://github.com/calebbuahin/SWMMOpenMIComponent

[dickinsonre]

Hello Bryant, Water quality is pretty easy. Are you looking for this type of simple model - models that test only one feature at a time?
http://www.swmm5.net/2017/04/swmm5-simple-100-mm-rainfall-model-for.html

[goanpeca]

@dickinsonre that would be sweet :-) like "unit testing"

[dickinsonre]

Okay, i have a box account with all SWMM3, SWMM4, SWMM5 testing file, I am attempting to add the links here
https://app.box.com/files/0/f/1453190976

https://app.box.com/files/0/f/1690982616

https://app.box.com/files/0/f/14088748

https://app.box.com/files/0/f/1453190976

[bemcdonnell]

@dickinsonre, Thanks for sharing. As we move toward automated regression testing we can use some of the concepts here for inspiration!