search

pyswmm / Stormwater-Management-Model

PySWMM Stormwater Management Model repository
Other
99 stars 77 forks source link

Phase out maintaining ci-tools as a submodule #327

Closed michaeltryby closed 3 years ago

michaeltryby commented 3 years ago

So we were having some problems with Actions CI over the weekend and I think I figured out what was happening.

Recently @Caleb and I have been pinning down package version over in the ci-tools repository. The ci-tools submodule needs to point to these newer commits in order to work properly.

The original thought was to keep the ci-tools submodule around so that it would be easy to run tests locally. But it appears that no one uses them for local testing.

It might be easier to modify the Actions script to do this automatically, rather then having the ci-tools submodule in the repository. This would eliminate the need for developers to update the ci-tools submodule on their own.

Addressing this issue involves deprecating the ci-tools submodule and configuring Actions to clone ci-tools repo on the build runner as part of the build / test workflow.

cbuahin commented 3 years ago

This issue has been addressed through #322

michaeltryby commented 3 years ago

@cbuahin Nice!