Closed michaeltryby closed 2 years ago
@cbuahin Couple of things are accomplished in this PR:
Will this PR include changes to SWMM report file to include build source?
@jennwuu as per your request I performed the updates discussed in Issue #352.
@michaeltryby Why is window build failing?
Fixed an MSVC syntax error. Switched over to a cmake generated export header so we can export functions with pointers as return values. This greatly simplifies working with VERSION and BUILD_ID strings.
This PR is ready for review.
Hi @michaeltryby just to double check, we are aware that ubuntu build is not working atm right? I recall a conversation related to that in another PR.
Yes I recommend we fix that in another PR.
@jennwuu I built the PR using WSL Ubuntu. Everything checks out.
Oops!
This PR configures cmake to automatically generate a
version.h
file for SWMM includingThe build option GEN_VER_HEADER has been defined to control version header generation. For example, during development the version header "rolls" with the most current information. During release, however, we will freeze the information in the version header.
See discussion in Issue #352