pyswmm / Stormwater-Management-Model

PySWMM Stormwater Management Model repository
Other
99 stars 77 forks source link

Automatic generation of version header #355

Closed michaeltryby closed 2 years ago

michaeltryby commented 2 years ago

This PR configures cmake to automatically generate a version.h file for SWMM including

The build option GEN_VER_HEADER has been defined to control version header generation. For example, during development the version header "rolls" with the most current information. During release, however, we will freeze the information in the version header.

See discussion in Issue #352

michaeltryby commented 2 years ago

@cbuahin Couple of things are accomplished in this PR:

jennwuu commented 2 years ago

Will this PR include changes to SWMM report file to include build source?

michaeltryby commented 2 years ago

@jennwuu as per your request I performed the updates discussed in Issue #352.

jennwuu commented 2 years ago

@michaeltryby Why is window build failing?

michaeltryby commented 2 years ago

Fixed an MSVC syntax error. Switched over to a cmake generated export header so we can export functions with pointers as return values. This greatly simplifies working with VERSION and BUILD_ID strings.

michaeltryby commented 2 years ago

This PR is ready for review.

jennwuu commented 2 years ago

Hi @michaeltryby just to double check, we are aware that ubuntu build is not working atm right? I recall a conversation related to that in another PR.

michaeltryby commented 2 years ago

Yes I recommend we fix that in another PR.

michaeltryby commented 2 years ago

@jennwuu I built the PR using WSL Ubuntu. Everything checks out.

michaeltryby commented 2 years ago

Oops!