search

pyswmm / Stormwater-Management-Model

PySWMM Stormwater Management Model repository
Other
99 stars 77 forks source link

solver/routing: Apply shell sort to event list #358

Closed easyteacher closed 1 year ago

easyteacher commented 2 years ago

Shell sort is faster than Insertion sort, and can produce the same result as the original algorithm.

bemcdonnell commented 2 years ago

@easyteacher, nice to meet you! Would you mind taking a minute to introduce yourself? I saw your original comment in the USEPA SWMM repo (not a lot of open development happening there so you’ve come to the right spot). I approved the run. We can start talking about he proposed changes here

easyteacher commented 2 years ago

Would you mind taking a minute to introduce yourself?

Hi @bemcdonnell ! I am a student of Chongqing University from China, majoring in Civil Engineering. Recently I just started learning SWMM by reading the source code.

I think there is very little I can do to help the development of SWMM, but I still found one part in SWMM that could be improved.

Currently I am also contributing to KDE Plasma and has become a developer of KDE. If you are interested, you can see my contributions in https://invent.kde.org/fusionfuture .

dickinsonre commented 2 years ago

IMO, a better addition to PySWMM would be to port some of the calibration and statistics features of the SWMM5 Delphi Gui code - I am still not convinced improving a little-used feature such as events is needed.