search

pyswmm / Stormwater-Management-Model

PySWMM Stormwater Management Model repository
Other
99 stars 77 forks source link

Link and Node Pollutant Function Call #363

Closed abhiramm7 closed 2 years ago

abhiramm7 commented 2 years ago

As identified by @karosc, there is a type issue in the set link pollutant function declaration. Its needs to be updated to type from int.

See https://github.com/OpenWaterAnalytics/swmm-python/pull/94#issuecomment-1013919536 for more information on this issue.

@michaeltryby It is a small patch, can we do this first and then merge in https://github.com/OpenWaterAnalytics/swmm-python/pull/94 ?

karosc commented 2 years ago

I'm wondering when someone can take a look at #364, the PR is holding up some advancements in swmm-python

abhiramm7 commented 2 years ago

Addressed in https://github.com/OpenWaterAnalytics/Stormwater-Management-Model/pull/372