pyswmm / Stormwater-Management-Model

PySWMM Stormwater Management Model repository
Other
99 stars 77 forks source link

Subcatchment runoff is missing LID runoff rate #370

Open jennwuu opened 2 years ago

jennwuu commented 2 years ago

The subcatchment runoff rate returned by the API endpoint is missing LID runoff rate. This issue is significant when LIDs cover the entire subcatchment.

https://github.com/OpenWaterAnalytics/Stormwater-Management-Model/blob/6d6b5272250acaa3939db9e265f0e593dc96e43e/src/solver/toolkit.c#L2150-L2191

https://github.com/OpenWaterAnalytics/Stormwater-Management-Model/blob/025337c026dc2b6d493fb23ab05016329f7547cb/src/solver/output.c#L588

https://github.com/OpenWaterAnalytics/Stormwater-Management-Model/blob/develop/src/solver/subcatch.c#L866-L932

https://github.com/OpenWaterAnalytics/Stormwater-Management-Model/blob/025337c026dc2b6d493fb23ab05016329f7547cb/src/solver/subcatch.c#L894-L905