pyswmm / Stormwater-Management-Model

PySWMM Stormwater Management Model repository
Other
99 stars 77 forks source link

Adding Hot Start File save-during-simulation feature #393

Closed bemcdonnell closed 1 year ago

bemcdonnell commented 1 year ago

Closes #253, Finally!

Replaces #252. I took the work for @jsadler2 and finally retooled it to bring it in to SWMM.

With this feature the users can save a HSF any time during a simulation.

jsadler2 commented 1 year ago

Wow! I'm truly impressed you kept this alive and finally finished it after this long, @bemcdonnell!

bemcdonnell commented 1 year ago

@jsadler2 trying to increase my follower count on GitHub… hahaha

abhiramm7 commented 1 year ago

@bemcdonnell looks like the Mac tests are not running. We might have to revert back to the 10.14 version.

bemcdonnell commented 1 year ago

@abhiramm7 thanks! Once I get review from @karosc ill merge!

bemcdonnell commented 1 year ago

Inspired by @jsadler2 many years ago.. It's finally time to merge it in! This feature could really change how we perform model calibrations and I am really excited to see it in action!