search

pyswmm / Stormwater-Management-Model

PySWMM Stormwater Management Model repository
Other
99 stars 77 forks source link

Node volume constraints when coupling with 2D models #397

Closed LllC-mmd closed 1 year ago

LllC-mmd commented 1 year ago

I am now developing a 2D-1D coupled hydrodynamic model where 1D hydraulic part uses SWMM as its backend.

In some discussion before #111 , I noticed there might be some constraints on the interchange flux between 2D surface and 1D sewer node based on available water storage in 2D surface area.

What I am interested that when there is drainage from 1D node to 2D surface cells, can I contain this flux by available water storage in 1D node retrieved by (https://github.com/pyswmm/Stormwater-Management-Model/blob/8266e4434bc9c23218bbf18fe57b0f3523d414ee/src/solver/node.c#L362).

Here I noticed that for non-storage nodes, it uses fullVolume to calculate the volume.

How does this quantity set in SWMM for non-storage nodes?

bemcdonnell commented 1 year ago

@LllC-mmd I saw your question was answered on SWMM-USERS. If there are some coupling features that would help your research, we'd be open to integrating some of these requests into the API here. I'm going to move this over to the Discussion section.