pyswmm / Stormwater-Management-Model

PySWMM Stormwater Management Model repository
Other
99 stars 77 forks source link

Fixed a bug in hotstart saveRouting method causing file corruption #399

Closed makusuko closed 1 year ago

makusuko commented 1 year ago

Fixed a bug in hostart saveRouting method: instead of saving the single pollutant buildup value, Nobjects[POLLUT] doubles would be saved rendering the file non-usable and causing serious issues and crashing when using the file.

bemcdonnell commented 1 year ago

@michaeltryby or @cbuahin does this PR make more sense to go to EPA rather than here?

cbuahin commented 1 year ago

@bemcdonnell and @makusuko, we are not at a point where we are able to accept direct PRs from non EPA employees yet. I can, however, create an issue on our end and make sure I provide credit to @makusuko when we create a new release. We are working on fleshing out the policy for accepting outside contributions. Thanks for letting us know @bemcdonnell, I appreciate it!

makusuko commented 1 year ago

Sure thing! I would be more than happy having this fixed in the EPA upstream -- no matter who does the fix.

bemcdonnell commented 1 year ago

@cbuahin is EPA taking this on? Can i close it here?

cbuahin commented 1 year ago

Yes @bemcdonnell please go ahead and close. I have already addressed it. It will be fixed in the next point release. Thank you for bringing it to my attention @bemcdonnell and @makusuko.

bemcdonnell commented 1 year ago

@cbuahin thanks!!