BuczynskiRafal
commented
1 year ago @aerispaha I'm glad you're preparing a solution, because I haven't found a solution that fixes the whole problem. I tried different approaches, but in the end I left it because it has the least impact on swmmio. In this state there is an error when joining tables, so I think the changes should be reversed. In the long run the unit test should be useful, I leave it to your judgment.
@BuczynskiRafal this is looking great so far! Excited to see this come together.
Keep in mind that we're also planning a longer-term solution to this issue by merging in logic from the swmm-pandas package developed by @karosc.
That said, I'm open to the type of solution you're working on here, at least to provide more coverage of the inp file in the near-term.