search

pyswmm / swmmio

Python tools for interacting with, editing, and visualizing EPA SWMM5 models
https://swmmio.readthedocs.io
MIT License
126 stars 41 forks source link

Calling float on a single element Series is deprecated #223

Open dirwin5 opened 2 months ago

dirwin5 commented 2 months ago

Getting multiple FutureWarnings in swmmio/graphics/profiler.py. FutureWarning: Calling float on a single element Series is deprecated and will raise a TypeError in the future. Use float(ser.iloc[0]) instead. I'll try to fix and submit a PR.

Affected lines: swmmio/graphics/profiler.py:35 swmmio/graphics/profiler.py:47 swmmio/graphics/profiler.py:57 swmmio/graphics/profiler.py:90 swmmio/graphics/profiler.py:94 swmmio/graphics/profiler.py:139 swmmio/graphics/profiler.py:140 swmmio/graphics/profiler.py:147 swmmio/graphics/profiler.py:148 swmmio/graphics/profiler.py:149 swmmio/graphics/profiler.py:277 swmmio/graphics/profiler.py:281 swmmio/graphics/profiler.py:301 swmmio/graphics/profiler.py:305

bemcdonnell commented 2 months ago

@dirwin5, thanks for noticing this. We’d love the PR if you have time. Was this a change in a recent release of pandas?

dirwin5 commented 2 months ago

Hi @bemcdonnell, yes it's pandas related, I believe since Pandas 2.0. There's an issue on the pandas-dev repo related to it here https://github.com/pandas-dev/pandas/issues/51101

I've drafted a PR, thanks.