pyt-team / TopoModelX

Topological Deep Learning
MIT License
222 stars 79 forks source link

More concrete types throughout the project #181

Closed ffl096 closed 1 year ago

ffl096 commented 1 year ago

Follow-up to #178 with more concrete types across the project, in particular for str-parameters with a well-defined set of allowed literals.

Ref. #174

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 95.83% and project coverage change: -0.05% :warning:

Comparison is base (dfbf508) 97.76% compared to head (79f7760) 97.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #181 +/- ## ========================================== - Coverage 97.76% 97.71% -0.05% ========================================== Files 35 35 Lines 1518 1534 +16 ========================================== + Hits 1484 1499 +15 - Misses 34 35 +1 ``` | [Files Changed](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team) | Coverage Δ | | |---|---|---| | [topomodelx/base/aggregation.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9iYXNlL2FnZ3JlZ2F0aW9uLnB5) | `100.00% <ø> (ø)` | | | [topomodelx/nn/simplicial/hsn\_layer.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9zaW1wbGljaWFsL2hzbl9sYXllci5weQ==) | `100.00% <ø> (ø)` | | | [topomodelx/nn/simplicial/scone\_layer\_bis.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9zaW1wbGljaWFsL3Njb25lX2xheWVyX2Jpcy5weQ==) | `100.00% <ø> (ø)` | | | [topomodelx/nn/hypergraph/hypersage\_layer.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9oeXBlcmdyYXBoL2h5cGVyc2FnZV9sYXllci5weQ==) | `98.30% <75.00%> (-1.70%)` | :arrow_down: | | [topomodelx/base/conv.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9iYXNlL2NvbnYucHk=) | `100.00% <100.00%> (ø)` | | | [topomodelx/base/message\_passing.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9iYXNlL21lc3NhZ2VfcGFzc2luZy5weQ==) | `100.00% <100.00%> (ø)` | | | [topomodelx/nn/cell/can\_layer.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9jZWxsL2Nhbl9sYXllci5weQ==) | `100.00% <100.00%> (ø)` | | | [topomodelx/nn/cell/can\_layer\_bis.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9jZWxsL2Nhbl9sYXllcl9iaXMucHk=) | `100.00% <100.00%> (ø)` | | | [topomodelx/nn/hypergraph/allset\_layer.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9oeXBlcmdyYXBoL2FsbHNldF9sYXllci5weQ==) | `91.80% <100.00%> (+0.27%)` | :arrow_up: | | [...pomodelx/nn/hypergraph/allset\_transformer\_layer.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9oeXBlcmdyYXBoL2FsbHNldF90cmFuc2Zvcm1lcl9sYXllci5weQ==) | `95.32% <100.00%> (+0.04%)` | :arrow_up: | | ... and [7 more](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/181?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.