pyt-team / TopoModelX

Topological Deep Learning
MIT License
222 stars 79 forks source link

Simplicial Complexes unit test cases added #184

Closed maneelusf closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

mhajij commented 1 year ago

@maneelusf can you please fix the lint errors? you need to have pre-commit install installed on your machine.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 99.66% and project coverage change: +0.63% :tada:

Comparison is base (844a5bf) 97.39% compared to head (b4d692a) 98.03%.

:exclamation: Current head b4d692a differs from pull request most recent head b877362. Consider uploading reports for the commit b877362 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #184 +/- ## ========================================== + Coverage 97.39% 98.03% +0.63% ========================================== Files 35 45 +10 Lines 1535 1831 +296 ========================================== + Hits 1495 1795 +300 + Misses 40 36 -4 ``` | [Files Changed](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team) | Coverage Δ | | |---|---|---| | [topomodelx/nn/simplicial/san.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9zaW1wbGljaWFsL3Nhbi5weQ==) | `96.42% <96.42%> (ø)` | | | [topomodelx/nn/simplicial/dist2cycle.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9zaW1wbGljaWFsL2Rpc3QyY3ljbGUucHk=) | `100.00% <100.00%> (ø)` | | | [topomodelx/nn/simplicial/hsn.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9zaW1wbGljaWFsL2hzbi5weQ==) | `100.00% <100.00%> (ø)` | | | [topomodelx/nn/simplicial/sca.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9zaW1wbGljaWFsL3NjYS5weQ==) | `100.00% <100.00%> (ø)` | | | [topomodelx/nn/simplicial/sccn.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9zaW1wbGljaWFsL3NjY24ucHk=) | `100.00% <100.00%> (ø)` | | | [topomodelx/nn/simplicial/sccnn.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9zaW1wbGljaWFsL3NjY25uLnB5) | `100.00% <100.00%> (ø)` | | | [topomodelx/nn/simplicial/scn2.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9zaW1wbGljaWFsL3NjbjIucHk=) | `100.00% <100.00%> (ø)` | | | [topomodelx/nn/simplicial/scnn.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9zaW1wbGljaWFsL3Njbm4ucHk=) | `100.00% <100.00%> (ø)` | | | [topomodelx/nn/simplicial/scone.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9zaW1wbGljaWFsL3Njb25lLnB5) | `100.00% <100.00%> (ø)` | | | [topomodelx/nn/simplicial/scone\_bis.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9zaW1wbGljaWFsL3Njb25lX2Jpcy5weQ==) | `100.00% <100.00%> (ø)` | | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/184/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team)

:umbrella: View full report in Codecov by Sentry.

:loudspeaker: Have feedback on the report? Share it here.