Closed ninamiolane closed 12 months ago
@ninamiolane
I have analyzed the runtime for all unit tests. Hypergraph Tutorials indeed do take the longest durations. Please find the times of the longest 5 tests here:
Category | Name | Run Time (sec) |
---|---|---|
Hypergraph | DHGCN. | 208 |
Hypergraph | Hypersage | 176 |
Hypergraph | UniGCNII. | 81 |
Hypergraph | UniGCN | 42 |
Simplicial | Scone | 27 |
My observations:
All steps are taking reasonable amount of time (< 5 secs) except the last step which is a 5 epoch training run for the DHGCN Hypergraph TNN.
Excellent, thanks for the very detailed diagnosis. I agree with all your points and the solutions.
iv. I like the naive solution of reducing the number of epochs from 5 to 1, together with a comment in the text explaining that in real applications that number should be increased. @devendragovil could you do this?
i-iii. These are awesome solutions, but would take more time. Maybe we can deprioritize them for now? (there are a lot of other tasks remaining).
@ninamiolane
yes I can do this. I can also implement the 3rd solution as well, I was independently working on the same for some time, and should hopefully be able to do it by Sunday. Will that work if I implement the 3rd solution by Sunday?
Independently of this issue, I also wanted to know if Sunday is a reasonable target to resolve all (or most in case of getting totally stuck in an issue) issues assigned to me?
Even better if you can do iii as well, thanks for offering!
Sunday is a perfect target of deadline 💯 Thanks for your great and fast work.
Thanks a lot!
@ninamiolane I fell ill after my travel back from India last week, so couldn't meet the timeline that I gave earlier. Sorry for that! I will try to complete all the issues asap. Thanks a lot for your consideration.
Thanks for the heads-up, and sorry to hear that you feel ill. Stay safe!
@devendragovil any update on this?
@ninamiolane Oh I am really sorry for the late response. I have raised a PR for this issue, run-times are now around 5.5-6 mins. I am stuck at one thing for a long time, it will help reduce overall run-time by 1-1.5 mins, but this PR helps reduce most of the time.
What?
Testing the tutorials on hypergraphs takes ~15 minutes, whereas testing the tutorials on other domains takes ~2-5 minutes (see screenshot).
There is probably one tutorial on hypergraphs that takes very long and slows down the whole github action workflow.
Find out which one and whether it can be accelerated.
Why?
A slow testing workflow slows down all the contributors, who have to wait for all tests to pass before being able to move on.