search

pyt-team / TopoModelX

Topological Deep Learning
MIT License
219 stars 79 forks source link

adding CCC #227

Closed mhajij closed 11 months ago

mhajij commented 11 months ago

adding CCC tutorial

review-notebook-app[bot] commented 11 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mhajij commented 11 months ago

@ninamiolane I think I addressed that issue, but there seems still to be differences between my local env and this one. Tests on my local env are passing.

ninamiolane commented 11 months ago

Tests need to pass on github. This seems to be a problem with mypy: you can click on "Details" next to the failing tests to see the exact logs.

mhajij commented 11 months ago

@ManuelLecha I cannot approve this PR before all tests pass.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e6be4f1) 96.36% compared to head (0261791) 96.54%. Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #227 +/- ## ========================================== + Coverage 96.36% 96.54% +0.18% ========================================== Files 55 58 +3 Lines 2036 2230 +194 ========================================== + Hits 1962 2153 +191 - Misses 74 77 +3 ``` | [Files](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team) | Coverage Δ | | |---|---|---| | [topomodelx/nn/combinatorial/hmc\_layer.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9jb21iaW5hdG9yaWFsL2htY19sYXllci5weQ==) | `100.00% <100.00%> (ø)` | | | [topomodelx/nn/combinatorial/hmc.py](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team#diff-dG9wb21vZGVseC9ubi9jb21iaW5hdG9yaWFsL2htYy5weQ==) | `88.88% <88.88%> (ø)` | | ... and [29 files with indirect coverage changes](https://app.codecov.io/gh/pyt-team/TopoModelX/pull/227/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pyt-team)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.