Closed gbg141 closed 9 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
c75ddd1
) 97.45% compared to head (d25a35b
) 97.45%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR mainly modifies
SCConv
andSCACMPS
tutorials and models to make them work. In our previoussimplicial_checks
PR we did not modify them because their tutorials needed to be re-written from scratch.Now they both run without problems using the Karate Club dataset. However,
SCConv
model still needs further revisions as the procedure to normalize the adjacencies is not properly working. In addition to this,SSConv
related incidence and adjacency notations are missleading; they may need to be reformulated, the current version is difficult to understand.