search

pyt-team / TopoModelX

Topological Deep Learning
MIT License
219 stars 79 forks source link

Simplicial checks #252

Closed gbg141 closed 9 months ago

gbg141 commented 9 months ago

This PR mainly modifies SCConv and SCACMPS tutorials and models to make them work. In our previous simplicial_checks PR we did not modify them because their tutorials needed to be re-written from scratch.

Now they both run without problems using the Karate Club dataset. However, SCConv model still needs further revisions as the procedure to normalize the adjacencies is not properly working. In addition to this, SSConv related incidence and adjacency notations are missleading; they may need to be reformulated, the current version is difficult to understand.

review-notebook-app[bot] commented 9 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c75ddd1) 97.45% compared to head (d25a35b) 97.45%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #252 +/- ## ========================================== - Coverage 97.45% 97.45% -0.01% ========================================== Files 57 58 +1 Lines 2121 2120 -1 ========================================== - Hits 2067 2066 -1 Misses 54 54 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.