search

pyt-team / TopoModelX

Topological Deep Learning
MIT License
219 stars 79 forks source link

Check hypergraphs #256

Closed Coerulatus closed 5 months ago

Coerulatus commented 9 months ago

247

Changed the hypergraph models to use the Conv class defined in this library. Due to how the attention is calculated it was not always feasible to use the Conv operation. Hypergat and hypersage still use their costume convolution functions.

review-notebook-app[bot] commented 9 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.36%. Comparing base (27e97ea) to head (c95265f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #256 +/- ## ========================================== + Coverage 97.07% 97.36% +0.29% ========================================== Files 58 58 Lines 2014 2050 +36 ========================================== + Hits 1955 1996 +41 + Misses 59 54 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Coerulatus commented 8 months ago

Thank you for the feedback! I resolved the mentioned issues

Coerulatus commented 6 months ago

Hello, I noticed that the pull request has not been accepted yet, and I was wondering if there might be any issues or concerns that need to be addressed. Thank you very much for your time and consideration.

ffl096 commented 6 months ago

This pull request has conflicts with the main branch that must be resolved before merging. Please rebase or merge the current main branch and resolve these conflicts :)

Coerulatus commented 5 months ago

@ffl096 Hi Florian, I have resolved the conflicts. Let me know if there is anything else! Thank you very much.