240 review nncell and nncombinatorial models + Fixed SAN bugs

gbg141 commented 9 months ago

This pull request addresses the following points:

Refactorization of cell and combinatorial models, decoupling the readout function from their implementation (analogous to what was already implemented for simplicial and hypergraph architectures, PRs #250 and #249). Models, notebooks and tests have been updated.
Solved two bugs in SAN implementation --it was not possible to train it on GPU.

review-notebook-app[bot] commented 9 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (aa07026) 97.45% compared to head (cb7f074) 97.40%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #269 +/- ## ========================================== - Coverage 97.45% 97.40% -0.05% ========================================== Files 58 58 Lines 2120 2084 -36 ========================================== - Hits 2066 2030 -36 Misses 54 54 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pyt-team / TopoModelX

240 review nncell and nncombinatorial models + Fixed SAN bugs #269

Codecov Report