Closed gbg141 closed 5 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Attention: Patch coverage is 96.87500%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 97.37%. Comparing base (
8ea75a7
) to head (db96096
).
Files | Patch % | Lines |
---|---|---|
topomodelx/nn/cell/can.py | 88.88% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request aims to update the input logic of cell complex models by
adjacency_r
,incidence_r
,down_laplacian_r
, etc.);**kwargs
optional parameter to models and layers, hence allowing the flexibility to modify additional parameters of the model's inner layers (standard practice in other libraries such astorch_geometric
).Upon acceptance of these changes, similar modifications will be applied to Hypergraph, Simplicial, and Combinatorial models.