search

pyt-team / TopoModelX

Topological Deep Learning
MIT License
219 stars 79 forks source link

CAN Attention: standard management of `heads`and `out_channels` #276

Closed gbg141 closed 3 months ago

gbg141 commented 3 months ago

Standardizing the CAN attention mechanism. Now, as in other attention-based models, the argument out_channels actually represents the final number of output channels --i.e., it must be divisible by heads to successfully perform the attention mechanism.

Previously the actual output channels were computed as heads * out_channels, which could be misleading.

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.37%. Comparing base (2267768) to head (3652f91).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #276 +/- ## ======================================= Coverage 97.37% 97.37% ======================================= Files 58 58 Lines 2054 2055 +1 ======================================= + Hits 2000 2001 +1 Misses 54 54 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.